Update react-bootstrap imports#840
Merged
quicksnap merged 1 commit intoerikras:masterfrom Jan 24, 2016
markusjwetzel:master
Merged
Update react-bootstrap imports#840quicksnap merged 1 commit intoerikras:masterfrom markusjwetzel:master
quicksnap merged 1 commit intoerikras:masterfrom
markusjwetzel:master
Conversation
`import { Navbar, Nav, NavItem } from 'react-bootstrap';` includes all react-bootstrap modules. By including the modules explicitly (i.e. `import Navbar from 'react-bootstrap/lib/Navbar';`), we can decrease the size of the production js-file and speed up hot reloading drastically.
quicksnap
added a commit
that referenced
this pull request
Jan 24, 2016
Update react-bootstrap imports
Collaborator
|
Rad! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
import { Navbar, Nav, NavItem } from 'react-bootstrap';includes all react-bootstrap modules. By including the modules explicitly (i.e.import Navbar from 'react-bootstrap/lib/Navbar';), we can decrease the size of the production js-file and speed up hot reloading drastically.